Add definition for flags in IGVM_VHS_MEMORY_MAP_ENTRY #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-oo
reviewed
Nov 27, 2023
igvm_defs/src/lib.rs
Outdated
| #[bitfield(u16)] | ||
| #[derive(AsBytes, FromBytes, FromZeroes, PartialEq, Eq)] | ||
| pub struct MemoryMapEntryFlags { | ||
| /// memory is in the shared state, and an explicit call must be made to |
There was a problem hiding this comment.
Sorry to be pedantic, but do you mind making this a sentence (ie capitalize Memory and add a period). It shows up a bit nicer in the generated rustdocs that way.
There was a problem hiding this comment.
None of the other bitfield structs in this file use capital letters - perhaps the entire file should match a single desired standard?
msft-jlange
force-pushed
the
memory_map_flags
branch
from
738d27c to
5c2eefc
Compare
chris-oo
approved these changes
Nov 27, 2023
chris-oo
added a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add meaning for the flags field in the IGVM_VHS_MEMORY_MAP_ENTRY structure