handle None in serializer method

microsoft · Nov 7, 2024 · a0a3b84 · a0a3b84
1 parent 6faea06
commit a0a3b84
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/Kiota.Builder/Writers/Python/CodeMethodWriter.cs b/src/Kiota.Builder/Writers/Python/CodeMethodWriter.cs
@@ -647,12 +647,20 @@ private void WriteSerializerBodyForInheritedModel(bool inherits, CodeClass paren
         if (inherits)
             writer.WriteLine("super().serialize(writer)");
         foreach (var otherProp in parentClass
-                                        .GetPropertiesOfKind(CodePropertyKind.Custom)
-                                        .Where(static x => !x.ExistsInBaseType && !x.ReadOnly)
-                                        .OrderBy(static x => x.Name))
+                                    .GetPropertiesOfKind(CodePropertyKind.Custom)
+                                    .Where(static x => !x.ExistsInBaseType && !x.ReadOnly)
+                                    .OrderBy(static x => x.Name))
         {
             var serializationMethodName = GetSerializationMethodName(otherProp.Type);
-            writer.WriteLine($"writer.{serializationMethodName}(\"{otherProp.WireName}\", self.{otherProp.Name})");
+            var propertyName = otherProp.Name;
+            writer.WriteLine($"if self.{propertyName} is not None:");
+            writer.IncreaseIndent();
+            writer.WriteLine($"writer.{serializationMethodName}(\"{otherProp.WireName}\", self.{propertyName})");
+            writer.DecreaseIndent();
+            writer.WriteLine("else:");
+            writer.IncreaseIndent();
+            writer.WriteLine($"writer.{serializationMethodName}(\"{otherProp.WireName}\", None)");
+            writer.DecreaseIndent();
         }
     }
     private void WriteSerializerBodyForUnionModel(CodeClass parentClass, LanguageWriter writer)

diff --git a/src/Kiota.Builder/Writers/Python/PythonConventionService.cs b/src/Kiota.Builder/Writers/Python/PythonConventionService.cs
@@ -130,7 +130,7 @@ public bool IsPrimitiveType(string typeName)
     {
         return typeName switch
         {
-            "int" or "float" or "str" or "bool" => true,
+            "int" or "float" or "str" or "bool" or "None" => true,
             _ => false,
         };
     }