-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the ShortenFileName() function to have only 100 characters #4906
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Do we need to wait up for the latest release for github.com/microsoftgraph/msgraph-beta-sdk-go v0.105.1? or this should update it |
we're usually shipping new releases for the Microsoft Graph SDK weekly. However, it was decided that weekly releases would be paused for July & August. CC @sebastienlevert |
ACK |
you could generate your own client using kiota for the operations you need instead on relying on the pre-packaged SDK. |
Great contribution @omhpathak 🎉 |
Fixing the issue here microsoftgraph/msgraph-beta-sdk-go#364 + the error received here:
github.com/microsoftgraph/msgraph-beta-sdk-go: readdirent /go/pkg/mod/github.com/microsoftgraph/[email protected]: file name too long | 7.942 make: *** [Makefile:52: clean] Error 1
When running Go build through docker, the build process complained about the file name being too long even though it looks like it's under 251.
Limiting the characters to 100 should fix it for most environments accounting for trailing whitespaces as well as any long file paths.