Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the ShortenFileName() function to have only 100 characters #4906

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

omhpathak
Copy link
Contributor

@omhpathak omhpathak commented Jun 28, 2024

Fixing the issue here microsoftgraph/msgraph-beta-sdk-go#364 + the error received here:
github.com/microsoftgraph/msgraph-beta-sdk-go: readdirent /go/pkg/mod/github.com/microsoftgraph/[email protected]: file name too long   | 7.942 make: *** [Makefile:52: clean] Error 1
When running Go build through docker, the build process complained about the file name being too long even though it looks like it's under 251.

Limiting the characters to 100 should fix it for most environments accounting for trailing whitespaces as well as any long file paths.

@omhpathak omhpathak requested a review from a team as a code owner June 28, 2024 16:00
@omhpathak
Copy link
Contributor Author

@omhpathak please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, left a comment

src/Kiota.Builder/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
@andrueastman andrueastman reopened this Jul 1, 2024
andrueastman
andrueastman previously approved these changes Jul 1, 2024
baywet
baywet previously approved these changes Jul 2, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet dismissed stale reviews from andrueastman and themself via c78cb89 July 2, 2024 13:29
@baywet baywet enabled auto-merge (squash) July 2, 2024 13:30
@baywet baywet merged commit 46ff436 into microsoft:main Jul 2, 2024
206 checks passed
@omhpathak omhpathak deleted the fix-shorten-file-path branch July 9, 2024 15:39
@omhpathak
Copy link
Contributor Author

Do we need to wait up for the latest release for github.com/microsoftgraph/msgraph-beta-sdk-go v0.105.1?

or this should update it

@baywet
Copy link
Member

baywet commented Jul 9, 2024

we're usually shipping new releases for the Microsoft Graph SDK weekly. However, it was decided that weekly releases would be paused for July & August. CC @sebastienlevert

@omhpathak
Copy link
Contributor Author

ACK
do we know if there is a short term solution to this in the meantime?
I get the error in the issue with a docker container.

@baywet
Copy link
Member

baywet commented Jul 9, 2024

you could generate your own client using kiota for the operations you need instead on relying on the pre-packaged SDK.

@avedmala
Copy link

Great contribution @omhpathak 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants