Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes comparer across runs in the KiotaLock #4923

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fixes comparer across runs in the KiotaLock #4923

merged 3 commits into from
Jul 2, 2024

Conversation

andrueastman
Copy link
Member

Closes #4916

@andrueastman andrueastman mentioned this pull request Jul 2, 2024
Closed
@andrueastman andrueastman marked this pull request as ready for review July 2, 2024 10:58
@andrueastman andrueastman requested a review from a team as a code owner July 2, 2024 10:58
@andrueastman andrueastman enabled auto-merge July 2, 2024 10:58
baywet
baywet previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that. We might have the same issue with workspace comparisons.

@andrueastman
Copy link
Member Author

Thanks for fixing that. We might have the same issue with workspace comparisons.

Update the PR to capture scenarios on the Workspace side as well.

@andrueastman andrueastman requested a review from baywet July 2, 2024 13:09
@andrueastman andrueastman disabled auto-merge July 2, 2024 13:10
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrueastman andrueastman merged commit c5f1679 into main Jul 2, 2024
207 checks passed
@andrueastman andrueastman deleted the andrueastman/Fixcomparer branch July 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@SilasKenneth SilasKenneth SilasKenneth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifying None as serializer/deserializer breaks kiota update
3 participants
@andrueastman @baywet @SilasKenneth