Fix ErrorMessageOverride
collision with classname
#4930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4893
In summary, this PR
ReplaceReservedExceptionPropertyNames
method to also rename the error class if it is the same name as a reserved class to avoid collision with class name and property name.AddPrimaryErrorMessage
to rename existing matching properties if they already exist in the error model to avoid information/property loss (otherwise we will fail to add the override and lead to invalid generation)Essentially, in a scenario where a
ErrorMessageOverride
property kind namedmessage
is added,message
, the model class will be renamed to avoid class and property name collision.