WIP: Add target for net9.0 for kiota tool #6006
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
reviewed
Jan 14, 2025
| @@ -3,7 +3,7 @@ | |||
| <LangVersion>Latest</LangVersion> | |||
| <Nullable>enable</Nullable> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFrameworks>net8.0;net9.0;</TargetFrameworks> | |||
There was a problem hiding this comment.
why keep both targets if our releasing pipeline only publishes net9?
There was a problem hiding this comment.
(I'm unsure about this tbh. I still need to validate this first)
Given that we'll still publish this as a nuget tool, won't having the target as only net 9 break the users running the tool using net8.0?
In my head, the two targets are not for the purposes for the binaries but really for the nuget tool for users in net8.0 and 9.0.
There was a problem hiding this comment.
in that case the -f net9.0 in the azure devops pipeline needs to be removed I believe.
| @@ -2,7 +2,7 @@ | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <LangVersion>Latest</LangVersion> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFrameworks>net8.0;net9.0;</TargetFrameworks> | |||
There was a problem hiding this comment.
same question about multi-targeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5887
TODO