Checking if the file exists or not by simply opening and closing. #124

[Viddesh1]

Issue number #124

After:-

Traceback (most recent call last):
  File "C:\Users\Admin\Desktop\pdfextract\markitdown\src\markitdown\_markitdown.py", line 1289, in convert       
    with open(source, 'r'):
         ^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'test.xlsx'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Admin\Desktop\pdfextract\VK\two.py", line 4, in <module>
    result = md.convert("test.xlsx")
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\Desktop\pdfextract\markitdown\src\markitdown\_markitdown.py", line 1292, in convert       
    raise FileNotFoundError
FileNotFoundError

[gagb]

Why not use os.path.exists()?

[Viddesh1]

Hello @gagb ,

Thanks for taking a look.

        try:
            with open(source, 'r'):
                pass  # Just checking if the file can be opened; no need to read its contents.
        except FileNotFoundError:
            raise FileNotFoundError

with open("file_name.xlsx", "r") syntax checks if the file exists or not and also opens the file in read mode to see if the file is readable or not.

        if not os.path.exists(source):
            raise FileNotFoundError(f"File {source} does not exists. Please check")

os.path.exists("file_name.xlsx") checks if the file name with extension is exists or not. Does not read it content by opening it.

By using the os.path.exists the trace back look like below:- (much shorter)

Traceback (most recent call last):
  File "C:\Users\Admin\Desktop\pdfextract\VK\two.py", line 5, in <module>
    result = md.convert("test.xlsx")
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\Desktop\pdfextract\markitdown\src\markitdown\_markitdown.py", line 1295, in convert
    raise FileNotFoundError(f"File {source} does not exists. Please check.")
FileNotFoundError: File test.xlsx does not exists. Please check.

Regards!
Viddesh

[gagb]

Hello @gagb ,

Thanks for taking a look.

        try:
            with open(source, 'r'):
                pass  # Just checking if the file can be opened; no need to read its contents.
        except FileNotFoundError:
            raise FileNotFoundError

with open("file_name.xlsx", "r") syntax checks if the file exists or not and also opens the file in read mode to see if the file is readable or not.

        if not os.path.exists(source):
            raise FileNotFoundError(f"File {source} does not exists. Please check")

os.path.exists("file_name.xlsx") checks if the file name with extension is exists or not. Does not read it content by opening it.

By using the os.path.exists the trace back look like below:- (much shorter)

Traceback (most recent call last):
  File "C:\Users\Admin\Desktop\pdfextract\VK\two.py", line 5, in <module>
    result = md.convert("test.xlsx")
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\Desktop\pdfextract\markitdown\src\markitdown\_markitdown.py", line 1295, in convert
    raise FileNotFoundError(f"File {source} does not exists. Please check.")
FileNotFoundError: File test.xlsx does not exists. Please check.

Regards! Viddesh

What's an example of a case where file does exists but open throws an error?

[Viddesh1]

Hello @gagb ,

Find some of example below:-

1. File permission not provided by root user for read, write
2. File is a directory eg test.xlsx
3. File is locked
4. Invalid encoding. (may be)
5. File is corrupted.

Thanks!
Viddesh