Feat/save document converter result #157
Open
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
l-lumin
reviewed
Dec 21, 2024
Comment on lines
+149
to
+159
| def save(self, file_path: str, encoding: str = "utf-8") -> None: | ||
| """ | ||
| Save the converted document result `text_content` to a file. | ||
|
|
||
| params: | ||
| file_path: The path to save the document result to. | ||
| encoding: The encoding to use when writing the document. | ||
| """ | ||
| with open(file_path, "w", encoding=encoding) as f: | ||
| f.write(self.text_content) | ||
|
|
There was a problem hiding this comment.
it serves the same purpose as #116. could you refactor the code to use a single function for better reusability?
There was a problem hiding this comment.
sure @l-lumin,
I think it makes more sense to have the function to save the result into a file inside the DocumentConverterResult.
- I refactored the CLI to use this function.
- I also added an
encodingparameter to the arguments.
There was a problem hiding this comment.
Thank you. I think so too. Look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the awesome package :)
This is a simple PR that adds a new
savemethod to theDocumentConverterResultclass, making it easier to save the converted document result to a file.Changes:
DocumentConverterResultclass, which takes afile_pathand optional encoding parameter. The method writes thetext_contentto the specified file using the specified encoding.savemethod.