fix committed stat #930
Open
fix committed stat #930
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #929 |
|
As an alternative fix we could call |
|
Ha, interesting -- looks like I decreased the commit while it should have been increased since |
_mi_os_free reduces the stat by the full size without taking uncommitted sections into account. For this reason we have to add the uncommitted sections to the stat before calling it.
|
Hello! |
|
Ah, yes it is already in the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mi_os_free reduces the stat by the full size without taking uncommitted sections into account.
For this reason we have to add the uncommitted sections to the stat before calling it.