-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multiple Credentials in Kernel Mode Schannel #4096
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
=======================================
Coverage ? 85.97%
=======================================
Files ? 56
Lines ? 15521
Branches ? 0
=======================================
Hits ? 13344
Misses ? 2177
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Looks fine to me. |
4d1a3a6
to
7dc5e9c
Compare
Looks like this PR is causing some certificate error on our lab machines / VMs: |
This PR is currently blocked on bugs discovered in external components. |
|
@anrossi, kernel build failure
|
@@ -353,6 +353,8 @@ if(QUIC_TLS STREQUAL "schannel") | |||
list(APPEND QUIC_COMMON_DEFINES QUIC_DISABLE_CHACHA20_TESTS) | |||
message(STATUS "Enabling anonymous client auth tests") | |||
list(APPEND QUIC_COMMON_DEFINES QUIC_ENABLE_ANON_CLIENT_AUTH_TESTS) | |||
message(STATUS "Enabling certificate algorithm tests") | |||
list(APPEND QUIC_COMMON_DEFINES QUIC_ENABLE_CERT_ALG_TESTS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set these in the kernel mode projects?
Looks like all the new tests failed:
|
Description
Adds a new API to support passing multiple credetials to Schannel in kernel mode. Fixes #3141.
Testing
TODO
Documentation
TODO