Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU EP] Batch Norm Implementation #23525

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

prathikr
Copy link
Contributor

Increases operator coverage for webgpu ep.

@prathikr prathikr added the ep:WebGPU ort-web webgpu provider label Jan 29, 2025
github-actions[bot]

This comment was marked as outdated.

@guschmue
Copy link
Contributor

guschmue commented Feb 4, 2025

lgtm. Did you check that the ort unit test is testting the webgpu route?

guschmue
guschmue previously approved these changes Feb 4, 2025
Copy link
Contributor

@guschmue guschmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should follow Yulong's recommendation of using DataLayout

@prathikr
Copy link
Contributor Author

prathikr commented Feb 4, 2025

lgtm. Did you check that the ort unit test is testting the webgpu route?

yes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/webgpu/nn/batch_norm.cc Outdated Show resolved Hide resolved
onnxruntime/core/providers/webgpu/nn/batch_norm.h Outdated Show resolved Hide resolved
prathikr and others added 2 commits February 4, 2025 14:58
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@prathikr prathikr requested review from fs-eire and guschmue February 4, 2025 23:47
@prathikr prathikr merged commit 6b4f9c4 into main Feb 5, 2025
100 checks passed
@prathikr prathikr deleted the prathikrao/batch-norm-webgpu-ep branch February 5, 2025 01:38
sfatimar pushed a commit to intel/onnxruntime that referenced this pull request Feb 5, 2025
Increases operator coverage for webgpu ep.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants