[mobile] Add Android BrowserStack test project back #23551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70e3a23.
edgchen1
reviewed
Feb 4, 2025
csharp/test/Microsoft.ML.OnnxRuntime.Tests.MAUI/Microsoft.ML.OnnxRuntime.Tests.MAUI.csproj
Outdated
Show resolved
Hide resolved
edgchen1
previously approved these changes
Feb 4, 2025
edgchen1
approved these changes
Feb 4, 2025
sfatimar
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Feb 5, 2025
## Description Follow-up for microsoft#23383 and microsoft#23474 * Adds android BrowserStack test back in * Modifies MAUI csproj file to build into an APK ### Motivation and Context There were 2 issues with the previous PRs: 1. The updated MAUI .csproj file configuration failed when building to iOS and MacCatalyst. This caused problems in the packaging pipeline because we build all C# projects in the .soln file in the packaging pipeline. Removed the Mac & iOS build targets for now 3. The previous MAUI .csproj file configuration did not build into an APK. It was missing the `<OutputType>` XAML tag and the Android package type XAML tag.
sfatimar
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Feb 5, 2025
## Description Follow-up for microsoft#23383 and microsoft#23474 * Adds android BrowserStack test back in * Modifies MAUI csproj file to build into an APK ### Motivation and Context There were 2 issues with the previous PRs: 1. The updated MAUI .csproj file configuration failed when building to iOS and MacCatalyst. This caused problems in the packaging pipeline because we build all C# projects in the .soln file in the packaging pipeline. Removed the Mac & iOS build targets for now 3. The previous MAUI .csproj file configuration did not build into an APK. It was missing the `<OutputType>` XAML tag and the Android package type XAML tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #23383 and #23474
Motivation and Context
There were 2 issues with the previous PRs:
The updated MAUI .csproj file configuration failed when building to iOS and MacCatalyst. This caused problems in the packaging pipeline because we build all C# projects in the .soln file in the packaging pipeline. Removed the Mac & iOS build targets for now
The previous MAUI .csproj file configuration did not build into an APK. It was missing the
<OutputType>XAML tag and the Android package type XAML tag.