Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks for release - 1.8.1 Round 2 #8137

Merged
merged 14 commits into from
Jun 26, 2021

Conversation

harshithapv
Copy link
Contributor

@harshithapv harshithapv commented Jun 23, 2021

This PR has all the cherry picks for round two for release 1.8.1. Following are the list of 14 PRs:
Fix mac shared_provider warning (#8153) - Had conflicts
• Approved

Fix Python Cuda loading issues (#7939) - Had conflicts with #7873
• Approved

Ortmodule override torch.manual_seed() (#8131) - Had a conflict with #7513
• Approved

Update logic in props.xml to account for shared provider library changes release:1.8.1 triage:approved
#8138 by hariharans29 was merged 17 hours ago
• Approved

Add int64 as a required type to ConstantOfShape
release:1.8.1
#8128 by skottmckay was merged 13 hours ago• Approved

[Mobile package] Update required operator config with additional ops for newer version of Wav2Vec 2.
release:1.8.1 triage:approved
#8123 by edgchen1 was merged 15 hours ago• Approved

Fix 32bit Android java API crash
release:1.8.1 triage:approved
#8122 by gwang-msft was merged 17 hours ago• Approved

Fix input schema extraction for ORTModule
component:ortmodule component:training-frontend release:1.8.1 triage:approved
#8098 by thiagocrepaldi was merged 5 days ago• Approved

Add module attribute to ORTModule to support HuggingFace Trainer save_model – Had conflicts with #7819
component:ortmodule component:training-frontend release:1.8.1 triage:approved
#8088 by baijumeswani was merged 5 days ago• Approved

[Mobile package] Update required operator config with additional ops for wav2vec2.
release:1.8.1 triage:approved
#8079 by edgchen1 was merged 6 days ago• Approved

Linux GPU Nuget package missing shared provider files
release:1.8.1 triage:approved
#8066 by RyanUnderhill was merged 7 days ago• Approved

Add shape inference to custom symbolic functions – Had conflicts
component:ortmodule component:training-frontend release:1.8.1 triage:approved
#7937 by BowenBao was merged 15 days ago• Approved

Topo sort the model before saving
release:1.8.1 triage:approved
#7913 by wangyems was merged 21 days ago• Approved

Fix boost download url
release:1.8.1 triage:approved
#7843 by gwang-msft was merged 28 days ago• Approved

guoyu-wang and others added 9 commits June 22, 2021 23:55
* checkin toposort

* review comments

* revert and add TODO
**Description**: As title.

**Motivation and Context**
- PyTorch ONNX exporter heavily depends on ONNX shape inference to export accurate and efficient model. Custom symbolic function exports the op as contrib ops, thus exporter is unable to perform standard onnx shape inference. Models with dynamic shape inputs are affected.
…for wav2vec2. (#8079)

Add some additional ops to the mobile package that are needed for the wav2vec2 model.
* Fix 32bit Android java API crash

* fix code formating
…for newer version of Wav2Vec 2. (#8123)

This is an update to #8079
The sample application motivating the original update changed to use an updated version of the model. Now, fewer ops are required. This change removes the previously added ops which are no longer needed.
…ytorch converter for Pad. (#8128)

It's also used pointlessly for torch.tensor.repeat (although that usage should always be able to be constant folded).
@skottmckay
Copy link
Contributor

Can this be added please? #8128

@harshithapv
Copy link
Contributor Author

Can this be added please? #8128

done :)

@hariharans29
Copy link
Member

hariharans29 commented Jun 24, 2021

Could you take this in as well please ? #8138 CC: @faxu to approve the PR for cherry-picking.

@harshithapv harshithapv changed the title cherry picks for release - 1.8.1 round 2 Cherry picks for release - 1.8.1 round 2 Jun 25, 2021
@harshithapv harshithapv changed the title Cherry picks for release - 1.8.1 round 2 Cherry picks for release - 1.8.1 Round 2 Jun 25, 2021
@guoyu-wang
Copy link
Contributor

Could you take this #8153 as well?

baijumeswani
baijumeswani previously approved these changes Jun 25, 2021
@harshithapv harshithapv merged commit 2e55002 into rel-1.8.1 Jun 26, 2021
@harshithapv harshithapv deleted the havenka/cherry-picks1.8.1-round2 branch June 26, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.