chore: move channels into impl classes #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
move-channels-into-impl
branch
from
29d5e6e to
cd86343
Compare
yury-s
approved these changes
Dec 11, 2023
| @@ -136,4 +136,15 @@ private void UpdateEventSubscription(string eventName, bool enabled) | |||
| }), | |||
| true).IgnoreException(); | |||
| } | |||
|
|
|||
| internal Task<JsonElement?> SendMessageToServerAsync( | |||
There was a problem hiding this comment.
why do we need this specialization of the template?
There was a problem hiding this comment.
Some legacy, let me try to follow-up with that.
There was a problem hiding this comment.
Turns out we have it twice:
a) SendMessageToServerAsync without the generic gives you a JsonElement? back.
b) SendMessageToServerAsync with a generic which internally deserialises the JSON for you into some specific data structure T
So no need to follow-up!
|
This broke implementation: |
|
Thanks for filing, I created #2828 as a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.