chore: various channel follow-ups #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
channel-follow-ups
branch
from
1cbb6ca to
649d21a
Compare
mxschmitt
force-pushed
the
get-rid-of-channels-final
branch
from
1acbd42 to
47249a0
Compare
mxschmitt
force-pushed
the
channel-follow-ups
branch
from
649d21a to
6a76a44
Compare
yury-s
approved these changes
Dec 11, 2023
| @@ -87,3 +87,8 @@ internal static string EvaluationScript(string content, string path) | |||
| throw new ArgumentException("Either path or content property must be present"); | |||
| } | |||
| } | |||
|
|
|||
| internal class EvaluateArgumentGuidElement | |||
There was a problem hiding this comment.
Doesn't C# style gives preference to file per class?
There was a problem hiding this comment.
We do this already in other parts in order to keep the amount of source code files more clear.
| property.SetValue(objResult, ToExpectedType(kv.Value, property.PropertyType, visited)); | ||
| } | ||
| var property = Array.Find(t.GetProperties(), prop => string.Equals(prop.Name, kv.Key, StringComparison.OrdinalIgnoreCase)); | ||
| property?.SetValue(objResult, ToExpectedType(kv.Value, property.PropertyType, visited)); |
There was a problem hiding this comment.
What is the minimal .Net version that supports ?. operator, are we confident that we'll not need to build with it?
There was a problem hiding this comment.
.NET takes care of that via the TFM, we can use any newer C# language feature how we like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rebased on #2795 once landed.