Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update 'should work for canvas' test expectation #33685

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt added the CQ1 label Nov 19, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Nov 20, 2024

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the update-should-work-for-canvas-test-expectation branch from ce04864 to 1e1c552 Compare November 20, 2024 15:14
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Nov 20, 2024

This comment has been minimized.

Copy link
Contributor

Test results for "tests others"

1 flaky ⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:117:5 › should run component tests after editing test and component @realtime-time-runner-chromium-linux

21234 passed, 508 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

37130 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 6a32589 into microsoft:main Nov 20, 2024
101 of 110 checks passed
@mxschmitt mxschmitt deleted the update-should-work-for-canvas-test-expectation branch November 20, 2024 16:13
Copy link
Contributor

Test results for "tests 2"

5 failed
❌ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
❌ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

112 flaky ⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @channel-chromium-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @channel-chromium-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:492:5 › run-server › should saveAs videos from remote browser @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @chrome-beta-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @chrome-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-macos-latest
⚠️ [chromium-library] › library/selector-generator.spec.ts:240:5 › selector generator › should separate selectors by >> @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @chromium-headed-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:899:7 › cli codegen › should record omnibox navigations after performAction @chromium-headed-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:733:7 › cli codegen › should assert value on disabled input @chromium-headed-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-headed-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chromium-tip-of-tree-ubuntu-20.04
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @chromium-tip-of-tree-ubuntu-20.04
⚠️ [chromium-library] › library/inspector/pause.spec.ts:522:5 › pause › should record from debugger @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-page] › page/page-mouse.spec.ts:244:3 › should tween mouse movement @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1447:1 › should not record network actions @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/tap.spec.ts:22:3 › should send all of the correct events @smoke @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-csp.spec.ts:21:3 › should bypass CSP meta tag @smoke @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:146:3 › should not emit events about internal page @firefox-headed-windows-latest
⚠️ [firefox-library] › library/headful.spec.ts:195:3 › should not override viewport size when passed null @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:283:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:230:1 › should open console errors on click @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1350:1 › should remove noscript when javaScriptEnabled is set to true @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:368:5 › launchServer › should reject waitForSelector when browser closes @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:186:1 › should ignore binding from beforeunload @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:322:5 › launchServer › should set the browser connected state @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:125:5 › should connect to an existing cdp session twice @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:141:5 › launchServer › should be able to reconnect to a browser @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/pause.spec.ts:522:5 › pause › should record from debugger @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:299:7 › cli codegen › should fill japanese text @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:867:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1447:1 › should not record network actions @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:197:5 › post data › should compute content-length from post data @webkit-macos-14-large
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/screenshot.spec.ts:96:14 › page screenshot › should work with device scale factor and scale:css @webkit-ubuntu-20.04

242956 passed, 9549 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants