Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up headless-shell hacks #33967

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mxschmitt
Copy link
Member

This addresses #33964 (comment).

This comment has been minimized.

@mxschmitt mxschmitt closed this Dec 12, 2024
@mxschmitt mxschmitt reopened this Dec 12, 2024
@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch 2 times, most recently from d2ceeb0 to 74da212 Compare December 12, 2024 19:02

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch from 74da212 to 3dc9aeb Compare December 12, 2024 19:07
@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch from 3dc9aeb to 54efe7b Compare December 12, 2024 19:07

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:368:5 › launchServer › should reject waitForSelector when browser closes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37247 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 38758c0 into microsoft:main Dec 12, 2024
29 checks passed
@mxschmitt mxschmitt deleted the cleanup-headless-shell-hacks branch December 12, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants