Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client certificates fixes (#34873) and URL pattern support #34939

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+528 −51
Open

feat: client certificates fixes (#34873) and URL pattern support #34939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4863ba7
Allow extra domains in test socks proxy
mmacvicar Feb 25, 2025
c0197e4
Fix use of client certificates on hosts behind proxies.
mmacvicar Feb 25, 2025
275857f
Add lookup fixtures are passed to createSocket
mmacvicar Feb 27, 2025
2657eb5
Add pattern can be used to select client certificates
mmacvicar Feb 27, 2025
6948762
Add example with literal IP addresses.
mmacvicar Feb 27, 2025
0b76c01
Add explanation and source for Pattern implementation
mmacvicar Feb 27, 2025
c752493
Add client certificate patterns to the doc
mmacvicar Feb 27, 2025
745aa27
Remove no longer used function
mmacvicar Feb 27, 2025
e7044dc
Fix lint issue
mmacvicar Feb 27, 2025
87c3cb9
Update declarations
mmacvicar Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/api/params.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ Does not enforce fixed viewport, allows resizing window in the headed mode.

## context-option-clientCertificates
- `clientCertificates` <[Array]<[Object]>>
- `origin` <[string]> Exact origin that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
- `origin` <[string]> Exact origin or chromium enterprise policy style URL pattern that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding yet another pattern will definitely slow things down. If you absolutely need a pattern, use regex.

- `certPath` ?<[path]> Path to the file with the certificate in PEM format.
- `cert` ?<[Buffer]> Direct value of the certificate in PEM format.
- `keyPath` ?<[path]> Path to the file with the private key in PEM format.
Expand Down
12 changes: 8 additions & 4 deletions packages/playwright-client/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9740,7 +9740,8 @@ export interface Browser {
*/
clientCertificates?: Array<{
/**
* Exact origin that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
* Exact origin or chromium enterprise policy style URL pattern that the certificate is valid for. Origin includes
* `https` protocol, a hostname and optionally a port.
*/
origin: string;

Expand Down Expand Up @@ -14786,7 +14787,8 @@ export interface BrowserType<Unused = {}> {
*/
clientCertificates?: Array<{
/**
* Exact origin that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
* Exact origin or chromium enterprise policy style URL pattern that the certificate is valid for. Origin includes
* `https` protocol, a hostname and optionally a port.
*/
origin: string;

Expand Down Expand Up @@ -17490,7 +17492,8 @@ export interface APIRequest {
*/
clientCertificates?: Array<{
/**
* Exact origin that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
* Exact origin or chromium enterprise policy style URL pattern that the certificate is valid for. Origin includes
* `https` protocol, a hostname and optionally a port.
*/
origin: string;

Expand Down Expand Up @@ -21994,7 +21997,8 @@ export interface BrowserContextOptions {
*/
clientCertificates?: Array<{
/**
* Exact origin that the certificate is valid for. Origin includes `https` protocol, a hostname and optionally a port.
* Exact origin or chromium enterprise policy style URL pattern that the certificate is valid for. Origin includes
* `https` protocol, a hostname and optionally a port.
*/
origin: string;

Expand Down
Loading
Loading