Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit tests #201

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Refactor unit tests #201

merged 2 commits into from
Nov 19, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Nov 18, 2024

Ported unit tests refactoring from #199.

Changes

  • Moved some types out of an anonymous namespace in unit tests to avoid generating warnings of unused variables in a debug build.
  • Removed some warning suppressions in unit tests accordingly.

@mingxwa mingxwa requested review from tian-lt and guominrui November 18, 2024 14:16
@mingxwa mingxwa merged commit b61bab4 into microsoft:main Nov 19, 2024
7 checks passed
@mingxwa mingxwa deleted the user/mingxwa/refactor-tests branch November 19, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guominrui guominrui guominrui approved these changes

@tian-lt tian-lt tian-lt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingxwa @tian-lt @guominrui