Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using ref #128

Merged
merged 13 commits into from
Nov 16, 2021
Merged

Enable using ref #128

merged 13 commits into from
Nov 16, 2021

Conversation

asklar
Copy link
Member

@asklar asklar commented Sep 25, 2021

This rearchitects react-native-xaml to use class components instead of function components.
In many scenarios, it is necessary to be able to call methods on a view, for example starting video playback on a MediaPlayerElement via the Play() method.
In order to do that, there are two bits needed: 1) we must pass a React ref that identifies the view, and 2) there needs to be a method somewhere.
This PR hooks up the ability to codegen VM commands that are callable from JS

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner November 13, 2021 02:37
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

USAGE.md Show resolved Hide resolved
@asklar asklar merged commit 231e4f0 into main Nov 16, 2021
@asklar asklar deleted the withRefs branch November 16, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants