Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrapper constructor in ErrorAnalysisManager and RAIVisionInsights load call for RAI Vision Dashboard #2560

Merged
merged 1 commit into from
May 1, 2024

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix customer reported issue where RAIVisionInsights is not able to load a pytorch model, thus the RAI Vision component is able to run but there is no dynamic functionality for the dashboard. The error is only happening for torchvision models because they are evaluated with calls to predict function in ml-wrappers. However, the load call does not setup the model in a similar way to the init method, hence the predict call fails, and the dashboard fails to load. This PR fixes the wrap_model setup and adds a test case to validate dashboard can be saved and reloaded for torchvision models.

The error message is specifically:

TypeError: pic should be PIL Image or ndarray. Got <class 'numpy.float64'>

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-ea-vision-load-wrapper branch from 74e13c5 to 1e14a9a Compare April 26, 2024 18:17
1 similar comment
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (6026326) to head (f584557).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2560      +/-   ##
==========================================
- Coverage   78.61%   78.19%   -0.43%     
==========================================
  Files          36       36              
  Lines        2619     2628       +9     
==========================================
- Hits         2059     2055       -4     
- Misses        560      573      +13     
Flag Coverage Δ
unittests 78.19% <100.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-ea-vision-load-wrapper branch from 1e14a9a to f584557 Compare May 1, 2024 17:22
@imatiach-msft imatiach-msft merged commit 93eacce into main May 1, 2024
86 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-ea-vision-load-wrapper branch May 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants