Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flask to resolve notebook error " ImportError: cannot import name 'url_quote' from 'werkzeug.urls'" #2577

Closed
wants to merge 2 commits into from
Closed

Upgrade flask to resolve notebook error " ImportError: cannot import name 'url_quote' from 'werkzeug.urls'" #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56af917
Update requirements.txt
tongyu-microsoft Aug 1, 2024
a8f0a28
Update setup.py
tongyu-microsoft Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rai_core_flask/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Flask
Flask>=3.0.0
Flask-Cors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should already be getting the latest flask version since there is no pin here - so the question is what is downgrading flask instead of getting the latest version?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I thought import error was resolved after pining Werkzeug >= 3.0.0

flask-socketio
ipython<=7.16.3; python_version <= '3.6'
Expand Down
2 changes: 1 addition & 1 deletion rai_core_flask/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# The version must be incremented every time we push an update to pypi (but
# not before)
VERSION = "0.7.6"
VERSION = "0.7.7"

# supply contents of our README file as our package's long description
with open("README.md", "r") as fh:
Expand Down
Loading