Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: AzureCosmosDBNoSQLMemoryStore GetAsync with embeddings false implementation #7975

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

atiq-bs23
Copy link
Contributor

@atiq-bs23 atiq-bs23 commented Aug 8, 2024

Motivation and Context

GetAsync is returning with embedding even if the withEmbedding parameter is false.

Description

Current implementation will return MemoryRecord based on withEmbedding flag.

Note

The method isn't being called yet, but I updated it because the implementation was missing.

Contribution Checklist

@atiq-bs23 atiq-bs23 requested a review from a team as a code owner August 8, 2024 12:21
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Aug 8, 2024
@github-actions github-actions bot changed the title AzureCosmosDBNoSQLMemoryStore GetAsync with embeddings false implementation .Net: AzureCosmosDBNoSQLMemoryStore GetAsync with embeddings false implementation Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants