.Net: Fix Chroma notebook to actually use ChromaMemoryStore #9083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
sujitdmello
temporarily deployed
to
integration
GitHub Actions
Inactive
sujitdmello
temporarily deployed
to
integration
GitHub Actions
Inactive
sujitdmello
temporarily deployed
to
integration
GitHub Actions
Inactive
sujitdmello
temporarily deployed
to
integration
GitHub Actions
Inactive
sujitdmello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR applies to the dotnet implementation.
The 09-memory-with-chroma notebook uses the VolatileMemoryStore which appears to be a copy and paste from 06-memory-and-embeddings notebook. However, since the notebook wants to show the usage of Chroma, a small change has been made to use the actual ChromaMemoryStore instead.
Description
The notebook has been updated to include the Chroma connector package and use the ChromaMemoryStore class using the default URL http://localhost:8080 which is expected to be running in a Docker container as per the instructions in the notebook.
The notebook was tested with a Chroma instance, and it worked as expected.
Contribution Checklist