Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI #9183

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

.Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI #9183

wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 9, 2024 •
edited
Loading

This is part 1 of replatforming Semantic Kernel on top of Microsoft.Extensions.AI, making it possible to use IChatCompletionService instances as IChatClient instances, and vice versa, and similarly for IEmbeddingGenerationService and IEmbeddingGenerator. The next step after this is refactoring the connectors to use M.E.AI internally where relevant.

I'm opening this as a draft for three reasons:

  1. It bumps the version of System.Text.Json up to using the 9.0.0 package. That's currently a release candidate version, and will be GA in a few weeks.
  2. I still need to add tests and fix whatever bugs they find.
  3. We need to agree on exactly what surface area we want to expose. The limited set I have here is my starting recommendation.

@stephentoub stephentoub requested a review from a team as a code owner October 9, 2024 18:37
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core labels Oct 9, 2024
@github-actions github-actions bot changed the title Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI Oct 9, 2024
@stephentoub stephentoub marked this pull request as draft October 9, 2024 18:41
@stephentoub
Enable bidirectional adapters between SK interfaces and Microsoft.Ext…
9d7c4fc 
…ensions.AI

This is part 1 of replatforming Semantic Kernel on top of Microsoft.Extensions.AI, making it possible to use IChatCompletionService instances as IChatClient instances, and vice versa, and similarly for IEmbeddingGenerationService and IEmbeddingGenerator. The next step after this is refactoring the connectors to use M.E.AI internally where relevant.
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @markwallace-microsoft