.Net: Moving VectorStore abstractions and VolatileVectorStore #9207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation and Context This is the first PR in a set of multiple. We want the vector store abstractions to live in a new package called Microsoft.Extensions.VectorData.Abstractions and repoint all implementations to use this new package. #9094 ### Description - Add the new project and add all requires files to it. - Files are copied from Microsoft.SemanticKernel.Abstractions with their namespaces changed and the individual experimental flags removed. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
…t to solution (#9019) ### Motivation and Context We intend to move the volatile memory store to it's own project and rename it to InMemory. ### Description This is the first step of the process and involves creating the projects. Also moving all memory unit test projects into a separate solution folder to simply navigating the solution structure. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <[email protected]>
…ers to new package (#9189) ### Motivation and Context This is one PR in a set of multiple. We want the vector store abstractions to live in a new package called Microsoft.Extensions.VectorData.Abstractions and repoint all implementations to use this new package. ### Description - Removes the vector store abstractions from Microsoft.SemanticKernel.Abstractions - Repoints all usages to the new package Microsoft.Extensions.VectorData.Abstractions ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
…9191) ### Motivation and Context We want to rename VolatileVectorStore to InMemoryVectorStore and move it to it's own package so that we can reduce the dependency set of SK.Core and bring it in line with other connectors, plus use a more easy to understand name. #8953 ### Description - Copied all VolatileVectorStore classes to the new InMemory project and renamed to InMemory - Added obsolete tags to all VolatileVectorStore classes - Repointed all internal code that used Volatile to use InMemory ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
westey-m
had a problem deploying
to
integration
GitHub Actions
Failure
### Description Fixing up latest changes from main to match refactoring in branch. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
markwallace-microsoft
approved these changes
Oct 11, 2024
SergeyMenshykh
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
VectorStore abstractions are being abstracted into a separate library to allow database creators to more easily implement their own implementations. Since the package is targeted, it is easier to take a dependency on.
The volatile vector store naming has been confusing for some, so renaming to InMemory. It also brings additional dependencies to SK.Core which is undesirable so moving it to its own package to avoid this.
#8953
#9094
Description
Contribution Checklist