Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json): remove trailing commas in XamlStyler.json and consolegit2gitgilters.json #18657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonymByte-404
Copy link

@anonymByte-404 anonymByte-404 commented Mar 6, 2025

Summary of the Pull Request

This PR removes trailing commas from XamlStyler.json and consolegit2gitfilters.json, ensuring they follow valid JSON syntax. Trailing commas are not allowed in JSON and could cause parsing errors.

Detailed Description of the Pull

  • Removed the trailing commas from:
    • XamlStyler.json
    • consolegit2gitfilters.json
  • Ensured that both files now comply with proper JSON syntax
  • Prevents potential issues with JSON parsing in tools or scripts that depend on these files.

PR Checklist

  • Tests added/passed
  • Closes #xxx
  • Documentation updated
  • Schema updated

@anonymByte-404
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The two tools that consume these files--XamlStyler and git2git--are tolerant of trailing commas. No other tools consume these files.

Are you encountering an issue with either of those tools?

If not, I'd lean towards reducing changes in this area unless they're strictly necessary. 🙂

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 6, 2025
@anonymByte-404
Copy link
Author

If not, I'd lean towards reducing changes in this area unless they're strictly necessary. 🙂

Thanks for clarification! I didn't encounter an issue, but I made the change to ensure strict JSON compliance. If you prefer keeping the files as they are, I can close the PR. Let me know your preference.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 6, 2025
@anonymByte-404 anonymByte-404 deleted the fix/remove-trailing-commas-json branch March 9, 2025 02:34
@anonymByte-404 anonymByte-404 restored the fix/remove-trailing-commas-json branch March 9, 2025 02:40
@anonymByte-404 anonymByte-404 reopened this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants