Empty date string and format not supported on Windows

microsoft · Sep 14, 2021 · 9279eb5 · 9279eb5
1 parent 6c5504c
commit 9279eb5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/tests/datasets/test_utils.py b/tests/datasets/test_utils.py
@@ -212,7 +212,6 @@ def test_invalid_t(self) -> None:
 @pytest.mark.parametrize(
     "date_string,format,min_datetime,max_datetime",
     [
-        ("foo", "", datetime(1970, 1, 1).timestamp(), datetime.max.timestamp()),
         (
             "2021",
             "%Y",

diff --git a/torchgeo/datasets/utils.py b/torchgeo/datasets/utils.py
@@ -277,11 +277,7 @@ def disambiguate_timestamp(date_str: str, format: str) -> Tuple[float, float]:
 
     # TODO: This is really tedious, is there a better way to do this?
 
-    if not any([f"%{c}" in format for c in "yYcxG"]):
-        # No temporal info
-        mint = datetime(1970, 1, 1)
-        maxt = datetime.max
-    elif not any([f"%{c}" in format for c in "bBmjUWcxV"]):
+    if not any([f"%{c}" in format for c in "bBmjUWcxV"]):
         # Year resolution
         maxt = datetime(mint.year, 12, 31, 23, 59, 59, 999999)
     elif not any([f"%{c}" in format for c in "djcx"]):
-Original file line number
+Diff line change
@@ Expand Up / @@ -212,7 +212,6 @@ def test_invalid_t(self) -> None: @@
     @pytest.mark.parametrize(
         "date_string,format,min_datetime,max_datetime",
         [
-            ("foo", "", datetime(1970, 1, 1).timestamp(), datetime.max.timestamp()),
             (
                 "2021",
                 "%Y",
@@ Expand Down @@