Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CropHarvest Dataset #1677

Merged
merged 49 commits into from
Jan 19, 2024

Conversation

GeorgeHuber
Copy link
Contributor

@GeorgeHuber GeorgeHuber commented Oct 18, 2023

Draft PR to add cropharvest dataset to torchgeo.

  • Implement the dataset extending either GeoDataset or NonGeoDataset
  • Add the dataset definition to torchgeo/datasets/init.py
  • Add a data.py script to tests/data// that generates test data with the same directory structure/file naming conventions as the new dataset
  • Add appropriate tests with 100% test coverage to tests/datasets/
  • Add the dataset to docs/api/datasets.rst
  • Add the dataset metadata to either docs/api/geo_datasets.csv or docs/api/non_geo_datasets.csv

Sample plot for single pixel timeseries over 12 months:
Screenshot 2024-01-08 at 11 05 12 PM

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Oct 18, 2023
@GeorgeHuber GeorgeHuber marked this pull request as draft October 18, 2023 04:08
@adamjstewart adamjstewart added this to the 0.6.0 milestone Nov 2, 2023
@github-actions github-actions bot added the testing Continuous integration testing label Nov 3, 2023
@calebrob6
Copy link
Member

Thanks for the contribution @GeorgeHuber! Let me know if you want help with the linting / mypy (you can read more about it here https://torchgeo.readthedocs.io/en/latest/user/contributing.html#linters)

@GeorgeHuber GeorgeHuber marked this pull request as ready for review November 15, 2023 05:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2023
@GeorgeHuber

This comment was marked as resolved.

docs/api/non_geo_datasets.csv Outdated Show resolved Hide resolved
tests/data/cropharvest/data.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost finished! Just a couple typo fixes and questions left.

torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Show resolved Hide resolved
torchgeo/datasets/cropharvest.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 43d7133 into microsoft:main Jan 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants