Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add South America Soybean Datamodule #1856

Closed
wants to merge 0 commits into from
Closed

Add South America Soybean Datamodule #1856

wants to merge 0 commits into from

Conversation

cookie-kyu
Copy link
Contributor

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets testing Continuous integration testing labels Feb 6, 2024
@adamjstewart
Copy link
Collaborator

Also includes the commits from your previous PR. This is because you committed to main instead of to a branch. See https://torchgeo.readthedocs.io/en/stable/user/contributing.html#git for the recommended workflow.

@adamjstewart adamjstewart added this to the 0.6.0 milestone Feb 11, 2024
@github-actions github-actions bot added datamodules PyTorch Lightning datamodules documentation Improvements or additions to documentation testing Continuous integration testing and removed documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets testing Continuous integration testing labels Feb 12, 2024
@cookie-kyu cookie-kyu marked this pull request as ready for review February 16, 2024 07:54
@cookie-kyu cookie-kyu marked this pull request as draft February 17, 2024 01:07
@cookie-kyu cookie-kyu marked this pull request as ready for review February 22, 2024 23:54
@adamjstewart
Copy link
Collaborator

I have a bunch of suggested fixes, but don't have permission to push to your main branch. You should never ever commit directly to your main branch, you should always create a new branch first. You also have a ton of commits in this PR that have already been merged because of this. Let me know if you need help with git or want links to any tutorials.

adamjstewart
adamjstewart requested changes Mar 15, 2024
View reviewed changes
docs/api/datamodules.rst Outdated Show resolved Hide resolved
docs/api/datamodules.rst Outdated Show resolved Hide resolved
tests/conf/south_america_soybean_s2.yaml Outdated Show resolved Hide resolved
tests/conf/south_america_soybean_s2.yaml Outdated Show resolved Hide resolved
tests/conf/south_america_soybean_s2.yaml Outdated Show resolved Hide resolved
tests/data/south_america_soybean/data.py Outdated Show resolved Hide resolved
torchgeo/datamodules/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datamodules/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datamodules/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datamodules/south_america_soybean.py Outdated Show resolved Hide resolved
adamjstewart
adamjstewart requested changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased. I could do that for you, but you haven't given me permission to push to your main branch yet.

tests/conf/sentinel2_south_america_soybean.yaml Outdated
in_channels: 13
num_classes: 2
num_filters: 1
ignore_index: 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 2 classes, ignoring the 5th class doesn't mean anything

torchgeo/datamodules/south_america_soybean.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename to sentinel2_south_america_soybean.py

torchgeo/datamodules/south_america_soybean.py Outdated Show resolved Hide resolved
@cookie-kyu cookie-kyu closed this Mar 25, 2024
@adamjstewart adamjstewart removed this from the 0.6.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart requested changes

Assignees
No one assigned
Labels
datamodules PyTorch Lightning datamodules documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cookie-kyu @adamjstewart