-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Satlas pretrained models #1884
Conversation
…l Satlas single-image rgb&multispectral Swin-v2 models. Tests pass.
|
@microsoft-github-policy-service agree company="Allen Institute for AI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change but otherwise LGTM. @adamjstewart not sure if the CLA bot is broken or what's happening here
@microsoft-github-policy-service agree company="Allen Institute for AI" |
Looks like that last one did it 🤷♂️ |
Thanks Piper!! |
Woohoo! Thank you guys |
Swin_V2_B_Weights.NAIP_RGB_SI_SATLAS,3,`link <https://github.com/allenai/satlas>`__,`link <https://arxiv.org/abs/2211.15660>`__,"ODC-BY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for correcting this license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, but https://huggingface.co/allenai/satlas-pretrain has an Apache-2.0 license?
Another comment on this. Our unit tests do not actually attempt to download the model. We have separate tests for this that are only run before each release. If you run: > pytest -m slow tests/models/test_swin.py you'll see that these models fail due to:
We should either change the weights to be for the CPU (this is what we did for all other model weights in TorchGeo) or set the |
Also see #1916, I'm changing the URLs for all of our models to ensure that the md5 is reproducible even if you make this kind of change. |
* Documentation, satellite-specific transform and weights for additional Satlas single-image rgb&multispectral Swin-v2 models. Tests pass. * Address 3 of comments * Address comments, fix readmydocs and isort, mypy still unhappy * update * Add bands to meta dicts * Add comment about Satlas S2 RGB using TCI product * linting --------- Co-authored-by: Piper Wolters <[email protected]> Co-authored-by: Piper Wolters <[email protected]>
* initial commit * add init description * correct scanning of files in init * added random data generation * remove test directory * Update metadata * fix formatting * add s1 data and update regex * fix dataset and add tests * formatting * mypy * add timeseries test and take images from july * fix bug in merging files across dates * mypy * Bump lightly from 1.4.25 to 1.5.0 in /requirements (#1894) * Additional Satlas pretrained models (#1884) * Documentation, satellite-specific transform and weights for additional Satlas single-image rgb&multispectral Swin-v2 models. Tests pass. * Address 3 of comments * Address comments, fix readmydocs and isort, mypy still unhappy * update * Add bands to meta dicts * Add comment about Satlas S2 RGB using TCI product * linting --------- Co-authored-by: Piper Wolters <[email protected]> Co-authored-by: Piper Wolters <[email protected]> * Update tests/data/south_africa_crop_type/data.py Co-authored-by: Adam J. Stewart <[email protected]> * Update tests/data/south_africa_crop_type/data.py Co-authored-by: Adam J. Stewart <[email protected]> * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * refactor gettitem and bug fixes * typo * data.py style * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * added comments for nonstandard functionality * Update torchgeo/datasets/south_africa_crop_type.py Co-authored-by: Adam J. Stewart <[email protected]> * small change * add verbose documentation --------- Co-authored-by: georgehuber <“[email protected]”> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piper Wolters <[email protected]> Co-authored-by: Piper Wolters <[email protected]> Co-authored-by: Piper Wolters <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]>
@piperwolters did you ever get a chance to apply the change requests here? |
Soft reminder @piperwolters 😅 |
Documentation, satellite-specific transforms, and weights for additional Satlas single-image RGB & multispectral Swin-v2 models. Tests pass.
Few things: