Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Make CI slow by validating against master definitely typed #718

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make CI slow by validating against master definitely typed #718

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ad58ce
Make CI slow by validating against master definitely typed
orta Dec 13, 2019
9b1e322
Cache the cache
orta Dec 13, 2019
b20744e
Make it not do the full npm lookup business
orta Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ language: node_js
node_js:
- 'node'

cache:
directories:
- cache/

sudo: false

branches:
Expand All @@ -11,6 +15,14 @@ branches:

install:
- npm ci
- git clone https://github.com/DefinitelyTyped/DefinitelyTyped ../DefinitelyTyped

script:
- npm tes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- npm tes
- npm test

- npm run build
- npm run clean
- npm run parse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on a cache to avoid querying npm for everything. It is NOT the most reliable cache, and I don't understand travis' caching strategy. You should test to see whether it's running npm info on every @types package for every CI run. If it's not, then you need to make sure that it's correctly running npm info on packages that were recently updated in DT.

- npm run check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This isn't very valuable, it mostly just tells you what @types packages are superceded by in-package types.
  2. On the other hand, we shouldn't never run it.
  3. On the third hand, it'll make CI slow.
  4. Is CI never not slow?
  5. This is probably the right place to run it.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should npm run calculate-versions and npm run generate and npm run index.

Note that some of these tasks hit npm (parse, index and maybe generate?)

git:
depth: 1