Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update playwright #2606

Merged
merged 11 commits into from
Oct 30, 2023
Merged

update playwright #2606

merged 11 commits into from
Oct 30, 2023

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Oct 26, 2023 •
edited
Loading

fix #2457

@github-actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2606/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2606/

@timotheeguerin timotheeguerin marked this pull request as ready for review October 26, 2023 20:03
markcowl
markcowl requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add this installation step to contributing.md

Otherwise, lgtm

@timotheeguerin timotheeguerin enabled auto-merge (squash) October 30, 2023 19:30
@timotheeguerin timotheeguerin merged commit f1daf15 into main Oct 30, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the upgrade/playwright branch October 30, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update playwright
2 participants
@timotheeguerin @markcowl