Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rekey in Rekeyable map shouldn't keep target item if rekeying to existing key #2607

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Fix: Rekey in Rekeyable map shouldn't keep target item if rekeying to existing key #2607

merged 3 commits into from
Nov 1, 2023

Conversation

timotheeguerin
Copy link
Member

fix #2489

@github-actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2607/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2607/

@timotheeguerin timotheeguerin enabled auto-merge (squash) November 1, 2023 14:52
@timotheeguerin timotheeguerin merged commit dc95c54 into microsoft:main Nov 1, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the fix/rekeyable-map branch November 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson approved these changes

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in rekeyableMap when rekeying an entry to an existing one
2 participants
@timotheeguerin @bterlson