Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve alias of alias #2627

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Resolve alias of alias #2627

merged 2 commits into from
Nov 2, 2023

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Nov 2, 2023 •
edited
Loading

fix #2626

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2627/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2627/

mikeharder
mikeharder approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixes the issue in typespec-next

@timotheeguerin timotheeguerin merged commit af875c3 into microsoft:main Nov 2, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the fix/alias-of-alias branch November 2, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: 0.50.0-dev.11 Alias of alias broken
2 participants
@timotheeguerin @mikeharder