Adopt http\type\property\additional-properties #4463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
jorgerangel-msft
force-pushed
the
ap-serial
branch
from
f03141b
to
d0825ba
Compare
...cts/CadlRanch/http/type/model/inheritance/single-discriminator/src/Generated/Models/Eagle.cs
Show resolved
Hide resolved
jorgerangel-msft
force-pushed
the
ap-serial
branch
from
d0825ba
to
8bbc09f
Compare
jorgerangel-msft
requested review from
m-nash and
JoshLove-msft
as code owners
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Show resolved
Hide resolved
...ator.CSharp.ClientModel/test/Providers/MrwSerializationTypeDefinitions/JsonModelCoreTests.cs
Show resolved
Hide resolved
...-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Snippets/JsonElementSnippets.cs
Outdated
Show resolved
Hide resolved
...es/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/PropertyProvider.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serialization/deserialization of models with additional properties. It also addresses an issue discovered when serialization discriminated models.
fixes: #4007