Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace m2r with new typescript-based method #6091

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Replace m2r with new typescript-based method #6091

wants to merge 27 commits into from
+156 −85

Conversation

catalinaperalta
Copy link
Member

  • Remove m2r usage in the emitter
  • Add md2rst method to convert markdown to rst format
  • Add method to walk through yamlMap record

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Feb 21, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 21, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-client-python
Show changes

@typespec/http-client-python - internal ✏️

Remove m2r dependency in favor of internally converting md to rst.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 21, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@catalinaperalta catalinaperalta marked this pull request as ready for review February 25, 2025 02:23
@catalinaperalta
Copy link
Member Author

@iscai-msft @msyyc @tadelesh I attempted to create the downstream PR but looks like it didnt work. Here is the pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4586228&view=results any advice on how to fix?

@msyyc
Copy link
Contributor

msyyc commented Feb 25, 2025

@iscai-msft @msyyc @tadelesh I attempted to create the downstream PR but looks like it didnt work. Here is the pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4586228&view=results any advice on how to fix?

You may forget to add " when trigger pipeline
image

@msyyc msyyc mentioned this pull request Feb 25, 2025
Closed
iscai-msft
iscai-msft approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing looks like you got the recursion working. approve, you can merge it whenevedr

@catalinaperalta catalinaperalta requested a review from lmazuel as a code owner March 6, 2025 23:57
@catalinaperalta catalinaperalta mentioned this pull request Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments

@iscai-msft iscai-msft iscai-msft approved these changes

@msyyc msyyc msyyc left review comments

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

Assignees
No one assigned
Labels
emitter:client:python Issue for the Python client emitter: @typespec/http-client-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@catalinaperalta @azure-sdk @msyyc @timotheeguerin @iscai-msft @cperaltah