rest - filter string constant path http properties when using @autoRoute
#6326
+71
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
witemple-msft and
AlitzelMendez
as code owners
timotheeguerin
approved these changes
Mar 7, 2025
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
archerzz
pushed a commit
to archerzz/typespec
that referenced
this pull request
Mar 10, 2025
…oute` (microsoft#6326) microsoft#6311 switched openapi3 to use `HttpProperty` instead of `HttpOperationParameter`. The `@typespec/rest` package did some filtering of parameters under a couple conditions (including path constants) that wasn't applied to properties. This caused an extra path parameter to be emitted in OpenAPI3 (and typespec-autorest when eventually applying the same changes there). This PR applies the same `@autoRoute` parameter filtering to properties. --------- Co-authored-by: Christopher Radek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6311 switched openapi3 to use
HttpPropertyinstead ofHttpOperationParameter. The@typespec/restpackage did some filtering of parameters under a couple conditions (including path constants) that wasn't applied to properties. This caused an extra path parameter to be emitted in OpenAPI3 (and typespec-autorest when eventually applying the same changes there).This PR applies the same
@autoRouteparameter filtering to properties.