Expose initScaffolding via an internals export #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
timotheeguerin
commented
Mar 8, 2025
There was a problem hiding this comment.
the reason for splitting this file is that it depends on teh diagnostcs which then start loading too many things that don't work well in the bundled vscode extension.
There is some refactoring that we need to do so boundaries are better.
|
You can try these changes here
|
timotheeguerin
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
chrisradek,
AlitzelMendez and
witemple-msft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory a better approach would probably move the init logic to a new package but I think this would require quite a refactor of our compiler to extract a lot of the utils.
Refactor a little bit to split compiler host from just a filesystem host which non compile operation should depend on.
So this is a cheap solution that is only meant for our own use case for now.