Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push main to live (2023.06.29) #101

Merged
merged 54 commits into from
Jul 17, 2023
Merged

Push main to live (2023.06.29) #101

merged 54 commits into from
Jul 17, 2023

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Jun 29, 2023

No description provided.

quyykk and others added 30 commits March 10, 2023 23:49
This adds clarification as to why the GHA binary caching provider is
using environment variables for configuration.
Remove internal only facing documents.
Add missing depend-info entry to the table of contents.
Changed first person wording to third person
Minor grammatical fixes, changed first person to third person
AugP and others added 6 commits June 26, 2023 14:54
Updated repo notification recipients .openpublishing.publish.config.json
Revert "Add guidance for handling usage files"
* Add docs for x-gha.

* Add mention of --x-binary-cache-github-actions.

* ACTIONS_CACHE_URL is the actual name

* Revert "Add mention of --x-binary-cache-github-actions."

This reverts commit f6ee7de.

* Add environment variables reference

* Improve GitHub Actions binary caching docs

This adds clarification as to why the GHA binary caching provider is
using environment variables for configuration.

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* guidance for usage files

* add usage example and fix formatting

* format

* Remove internal only facing documents.

* Fix misspellings

* wip

* Add missing depend-info entry to the table of contents.

* Update depend-info for --format.

* modify usage instructions

* Change title

* remove absolute links

* Update binarycaching.md

Changed first person wording to third person

* Update binarycaching.md

Minor grammatical fixes, changed first person to third person

* update depend-info documentation with mermaid support and format changes

* change examples to match our heuristics

* CPub style

* update main help message with mermaid support

* Initial documentation for GitHub dependency graph integration (#86)

* Adding an initial description of the experimental vcpkg integration with GitHub dependency graph.

* Adding an experimental features section to the documentation and adding the GitHub dependency graph page in there.

* Be more explicit about how to contact us with feedback.

* Fixing heading issues identified by GitHub Actions check

* Fixing a few minor issues.

* Adding text explaining how to enable dependency graph and updating the experimental notice to be more consistent with other experiments.

* Renaming file for GitHub integrations info and moving round in the TOC structure

* Fixing Learn publishing validation errors.

* Updating doc header information

* Updating headers to reflect that multiple topics will be covered on this page

* Adding high-level summary of the GitHub Packages caching integration

* Wording changes as suggested by @vicroms with very small tweaks.

* Fixing 2 incorrect paths to the experimental block.

* Updating some wording that I felt was too awkward and adding a note on having a vcpkg.json manifest for the example.

* Removing locales from linked-to URLs.

* Removing "Additionally" since it's an empty word.

* code blocking 'gh' to avoid machine translation issues (and to make it stand out more from the text).

* Moving GitHub Integration from the doc root to Consuming Libraries section

* Addressing feedback from @TylerMSFT and fixing link to file issues (against vcpkg instead of vcpkg-docs).

* Adding some nice and short anchor text to important sections (for better incoming links).

* Applying further copy-editing suggestions from @TylerMSFT.

I've left the casing of vcpkg untouched, even at the start of a sentence, due to product specific guidelines.

* Adding explicitly which version of vcpkg is required to enabled the feature.

* Applied comment from Victor on vcpkg/github-integration.md



* Apply comment suggestion on vcpkg/github-integration.md



* Removed an unnecessary newline

---------




* Feature/license features (#93)

* Add docs for licenses in features

* Update vcpkg/reference/vcpkg-json.md

---------



* Updated repo notification recipients .openpublishing.publish.config.json

* Revert "Add guidance for handling usage files"

---------

Co-authored-by: Robert Schumacher <[email protected]>
Co-authored-by: Augustin Popa <[email protected]>
Co-authored-by: quyykk <[email protected]>
Co-authored-by: Paul J. Davis <[email protected]>
Co-authored-by: dan-shaw <[email protected]>
Co-authored-by: Javier Matos Denizac <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>
Co-authored-by: myd7349 <[email protected]>
Co-authored-by: Wim Leflere <[email protected]>
Co-authored-by: Michael B. Price <[email protected]>
Co-authored-by: autoantwort <[email protected]>
@prmerger-automator
Copy link

@vicroms : Thanks for your contribution! The author(s) have been notified to review your proposed change. @michaelbprice

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c0498de:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit c0498dec010f3aa3c0f21ead8d6aef2e8c11800a in branch main of repository https://github.com/microsoft/vcpkg-docs into branch live (commit f04b0a5c3fe2afd17a03d3bc48e4bb3002b3c11d). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d981e52:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/github-integration.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@vicroms vicroms changed the title [do not merge] Sync test Push main to live (2023.06.29) Jun 29, 2023
* change ownership

* fix victor's alias

---------

Co-authored-by: TylerMSFT <[email protected]>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5daed28:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/docfx.json ✅Succeeded
vcpkg/github-integration.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0d83965:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/docfx.json ✅Succeeded
vcpkg/github-integration.md ✅Succeeded View
vcpkg/reference/vcpkg-json.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

* [VCPKG_KEEP_ENV_VARS] Note about known bug in recursive calls

* Rewrite example

* Revise text and code

* Remove note about fixed bug
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 72bc960:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/docfx.json ✅Succeeded
vcpkg/examples/asset-caching-source-nuget.md ✅Succeeded View
vcpkg/github-integration.md ✅Succeeded View
vcpkg/reference/vcpkg-json.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

* Remove keywords 'or' in Platform Expression

* Update vcpkg-json.md

Add text explaining

* apply patch

---------

Co-authored-by: LilyWangLL <[email protected]>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b1ab726:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/docfx.json ✅Succeeded
vcpkg/examples/asset-caching-source-nuget.md ✅Succeeded View
vcpkg/github-integration.md ✅Succeeded View
vcpkg/reference/vcpkg-json.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

* Add guidance for supplying usage files

* Revised text

* PR comments

* Update ms.date

* Apply suggestions from code review

Co-authored-by: Augustin Popa <[email protected]>

* Apply suggestions from code review

Co-authored-by: Augustin Popa <[email protected]>

* Add template example

* Apply suggestions from code review

Co-authored-by: Augustin Popa <[email protected]>

* Apply suggestions from code review

Co-authored-by: Augustin Popa <[email protected]>

---------

Co-authored-by: Javier Matos Denizac <[email protected]>
Co-authored-by: Augustin Popa <[email protected]>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 6722aab:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/docfx.json ✅Succeeded
vcpkg/examples/asset-caching-source-nuget.md ✅Succeeded View
vcpkg/github-integration.md ✅Succeeded View
vcpkg/maintainers/handling-usage-files.md ✅Succeeded View
vcpkg/reference/vcpkg-json.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AugP AugP merged commit 38ec178 into live Jul 17, 2023
@prmerger-automator
Copy link

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.

It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:

 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}

We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

@prmerger-automator
Copy link

PR 101 has been merged from microsoft:main to microsoft:live by AugP.

@quyykk, @davisp, @dan-shaw, @JavierMatosD, @BillyONeal, @myd7349, @ras0219-msft, @AugP, @WimLeflere, @vicroms, @michaelbprice, @autoantwort, @TylerMSFT, @LilyWangLL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.