Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[restinio] Update to 0.7.1 #35777

Merged
merged 5 commits into from
Dec 29, 2023
Merged

[restinio] Update to 0.7.1 #35777

merged 5 commits into from
Dec 29, 2023

Conversation

eao197
Copy link
Contributor

@eao197 eao197 commented Dec 19, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • [ ] The "supports" clause reflects platforms that may be fixed by this new version
  • [ ] Any fixed CI baseline entries are removed from that file.
  • [ ] Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rcane
Copy link

rcane commented Dec 19, 2023

I don't think that the option to use either standalone asio or boost.asio can be a port feature. Those two options are mutually exclusive. And a port feature should only add functionality to a port and not be used to implement alternatives.
So this option can only be overridden in a custom triplet file. I do this myself to use boost.asio with restinio in my triplet file like this

if(PORT MATCHES "restinio")
    set(VCPKG_CMAKE_CONFIGURE_OPTIONS
            -DRESTINIO_ASIO_SOURCE=boost
            -DRESTINIO_DEP_BOOST_ASIO=find
    )
endif()

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 20, 2023
@eao197
Copy link
Contributor Author

eao197 commented Dec 20, 2023

@rcane @BillyONeal

So it means that if someone wants to add RESTinio with Boost.Asio to his/her project's manifest file he/she need to write a custom triplet file instead of simple:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
    "name": "versions-test",
    "version": "1.0.0",
    "builtin-baseline": "64ca152891d6ab135c6c27881e7eb0ac2fa15bba",
    "dependencies": [
        {
            "name": "restinio",
            "features" : [ "boost-asio" ]
        },
        "json-dto",
        "sqlitecpp"
    ]
}

?

If so, then I think that it simply kills the advantages of vcpkg manifest files :(

Please take into account that some users do not know anything about CMake or/and vcpkg internals and just use vcpkg with VS .sln files without dealing with CMake.

What approach can be used instead of custom triplets? Maybe another port like "restinio-boost" that just binds RESTinio to Boost.Asio? So a user can specify "restinio" or "restinio-boost" in his/her vcpkg.json file.

@eao197
Copy link
Contributor Author

eao197 commented Dec 27, 2023

I've return the port to the old style, without features.

@MonicaLiu0311
Copy link
Contributor

If you're ready, please revert to "Ready for review".

@eao197 eao197 marked this pull request as ready for review December 27, 2023 07:07
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2023
@vicroms vicroms merged commit 695a696 into microsoft:master Dec 29, 2023
15 checks passed
@eao197 eao197 deleted the restinio-0.7.1 branch January 11, 2024 12:15
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* RESTinio updated to v.0.7.1.

* Fix format for manifest file.

* x-add-version for RESTinio-0.7.1.

* Fix port for RESTinio v.0.7.1.

* x-add-version for fixed RESTinio port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants