-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[restinio] Update to 0.7.1 #35777
[restinio] Update to 0.7.1 #35777
Conversation
I don't think that the option to use either standalone asio or boost.asio can be a port feature. Those two options are mutually exclusive. And a port feature should only add functionality to a port and not be used to implement alternatives.
|
So it means that if someone wants to add RESTinio with Boost.Asio to his/her project's manifest file he/she need to write a custom triplet file instead of simple: {
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
"name": "versions-test",
"version": "1.0.0",
"builtin-baseline": "64ca152891d6ab135c6c27881e7eb0ac2fa15bba",
"dependencies": [
{
"name": "restinio",
"features" : [ "boost-asio" ]
},
"json-dto",
"sqlitecpp"
]
} ? If so, then I think that it simply kills the advantages of vcpkg manifest files :( Please take into account that some users do not know anything about CMake or/and vcpkg internals and just use vcpkg with VS .sln files without dealing with CMake. What approach can be used instead of custom triplets? Maybe another port like "restinio-boost" that just binds RESTinio to Boost.Asio? So a user can specify "restinio" or "restinio-boost" in his/her vcpkg.json file. |
I've return the port to the old style, without features. |
If you're ready, please revert to "Ready for review". |
* RESTinio updated to v.0.7.1. * Fix format for manifest file. * x-add-version for RESTinio-0.7.1. * Fix port for RESTinio v.0.7.1. * x-add-version for fixed RESTinio port.
[ ] The "supports" clause reflects platforms that may be fixed by this new version[ ] Any fixed CI baseline entries are removed from that file.[ ] Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.