Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate Android NDK r26d in vcpkg CI #35851

Merged
merged 60 commits into from
Jun 11, 2024
Merged

Activate Android NDK r26d in vcpkg CI #35851

merged 60 commits into from
Jun 11, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 24, 2023

No description provided.

@dg0yt dg0yt force-pushed the android-r26 branch 3 times, most recently from a8aca1c to 5bbda53 Compare December 24, 2023 20:51
@dg0yt dg0yt mentioned this pull request Dec 26, 2023
Merged
2 tasks
@dg0yt dg0yt force-pushed the android-r26 branch 5 times, most recently from dd5ed27 to 8428581 Compare December 29, 2023 14:47
@dg0yt dg0yt mentioned this pull request Jan 1, 2024
Open
This was referenced Jan 9, 2024
Closed
Closed
Merged
@dg0yt dg0yt mentioned this pull request Jan 24, 2024
Closed
@dg0yt dg0yt changed the title [invalid] Test with NDK r26b Update ports for NDK r26b Jan 24, 2024
BillyONeal pushed a commit that referenced this pull request Apr 1, 2024
@dg0yt
[arrow] Fix android (#37878)
e58dac2 
Needed with NDK r26. Cherry-picked from #35851.
@dg0yt dg0yt mentioned this pull request Apr 2, 2024
Merged
BillyONeal pushed a commit that referenced this pull request Apr 3, 2024
@dg0yt
[libsodium] Fix arm builds (android NDK r26) (#37932)
11ed791 
Upstream patch, adjusted. Cherry-picked from
#35851.
Fixes #37423,
@dg0yt dg0yt mentioned this pull request Apr 30, 2024
Merged
@dg0yt dg0yt changed the title Update ports for NDK r26c Update ports for NDK r26d May 6, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented May 6, 2024

@BillyONeal Please add NDK r26 to the android images. IMO the PR cannot really transition to "ready for review" as long as it is needs to download the NDK.

@dg0yt dg0yt mentioned this pull request May 28, 2024
Merged
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 8, 2024

Now with NDK r26d from CI image 🚀:

Compiler found: /android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++

@dg0yt dg0yt changed the title Update ports for NDK r26d Activate Android NDK r26d in vcpkg CI Jun 8, 2024
@dg0yt dg0yt marked this pull request as ready for review June 9, 2024 05:48
@BillyONeal BillyONeal requested a review from data-queue June 11, 2024 00:48
data-queue
data-queue approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@data-queue data-queue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to remove the older NDK from the Dockerfile at some point. I don't want to block on this, so approving.

@BillyONeal BillyONeal merged commit e158d10 into microsoft:master Jun 11, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the updates @dg0yt !
Thanks for the review @data-queue !

@dg0yt dg0yt deleted the android-r26 branch June 11, 2024 20:27
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2024
@BillyONeal BillyONeal mentioned this pull request Jun 12, 2024
Closed
@Mengna-Li Mengna-Li mentioned this pull request Dec 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@data-queue data-queue data-queue approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @BillyONeal @data-queue @jimwang118