[sdflib] new port

[talregev]

• Changes comply with the maintainer guide.
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[talregev]

I didn't find sdflib name nor the maintainer on https://repology.org/
I create a PR for the patch file:
UPC-ViRVIG/SdfLib#15

This port is needed for update mujoco:
https://github.com/google-deepmind/mujoco/blob/main/cmake/MujocoDependencies.cmake#L198

[MonicaLiu0311]

When testing usage, the following error occurs:

-- Configuring done (5.8s)
CMake Error at E:/sdflib/installed/x64-windows/share/sdflib/SdfLibConfig.cmake:60 (set_target_properties):
  The link interface of target "SdfLib::SdfLib" contains:

    glm::glm

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  E:/sdflib/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:9 (find_package)


-- Generating done (0.0s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

test.cpp

#include <iostream>
#include "SdfLib/RealSdf.h"
using namespace std;
int main()

{

cout << "Hello CMake." << endl;

return 0;

}

CMakeLists.txt

cmake_minimum_required (VERSION 3.8)
set(CMAKE_TOOLCHAIN_FILE "E:/sdflib/scripts/buildsystems/vcpkg.cmake")
project ("test")
add_library (main "test.cpp")
find_package(SdfLib CONFIG REQUIRED)

target_link_libraries(main PRIVATE SdfLib::icg SdfLib::SdfLib)

[talregev]

When testing usage, the following error occurs:

-- Configuring done (5.8s)
CMake Error at E:/sdflib/installed/x64-windows/share/sdflib/SdfLibConfig.cmake:60 (set_target_properties):
  The link interface of target "SdfLib::SdfLib" contains:

    glm::glm

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  E:/sdflib/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:9 (find_package)


-- Generating done (0.0s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

test.cpp
CMakeLists.txt

@MonicaLiu0311
I added:

include(CMakeFindDependencyMacro)
find_dependency(glm CONFIG)
find_dependency(spdlog CONFIG)
find_dependency(cereal CONFIG)

Can you test the port again? Thank you for your review.

[talregev]

@MonicaLiu0311 The PR is ready for review.

[dg0yt]

It only takes three or four simple files to make a test port to automate the usage test. Example: https://github.com/microsoft/vcpkg/pull/43179/files

[talregev]

It only takes three or four simple files to make a test port to automate the usage test. Example: https://github.com/microsoft/vcpkg/pull/43179/files

I am in favor to add automated test port:
#40725

[MonicaLiu0311]

After the installation is complete, there is no usage, perhaps the patch is incorrect.

[talregev]

After the installation is complete, there is no usage, perhaps the patch is incorrect.

It because the file name is unofficial

[talregev]

@MonicaLiu0311 The PR is ready for review.

[talregev]

After the installation is complete, there is no usage, perhaps the patch is incorrect.

It because the file name is unofficial

I prefer to change back the file name and remove the prefix unofficial from file name. It will also help to detect this port by other ports (mujoco), and remove the manual usage. And just have unofficial in the name space.

Let me know if you agree to that change.

[talregev]

@MonicaLiu0311 I apply all your changes. Please review again. Thank you for your effort! 🙏🏻

[MonicaLiu0311]

The usage test passed on x64-windows (header files found).