[rapidxml] Fix gcc and clang build issue #43199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Digital Barriers"
On Friday 10 January 2025 at 13:48:23 GMT, microsoft-github-policy-service[bot] ***@***.***> wrote:
@tartanpaint the command you issued was incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
jimwang118
added
the
category:port-bug
|
Compile test pass with following triplets: |
vicroms
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Has this patch been submitted upstream? See our policy regarding patches
There was a problem hiding this comment.
An equivalent patch was submitted to the rapdixml project on 2013-09-21, but there have not been any rapidxml releases since 2013-04-26
https://sourceforge.net/p/rapidxml/bugs/16/
If preferred, I can include the exact patch from that link with adjusted paths and a comment referencing this issue.
There was a problem hiding this comment.
I've updated this PR with the "official" patch submitted to rapidxml via https://sourceforge.net/p/rapidxml/bugs/16/ with minor tweaks to the file paths to allow the patch to be applied via vcpkg.
…forge.net/p/rapidxml/bugs/16/ with path tweaks for applying via vcpkg
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 15, 2025
[rapidxml] Fix gcc and clang build issue (microsoft#43199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.