Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite3] update to 3.48.0 #43266

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[sqlite3] update to 3.48.0 #43266

wants to merge 6 commits into from

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Jan 15, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 15, 2025
@JonLiu1993 JonLiu1993 marked this pull request as draft January 15, 2025 07:16
@JonLiu1993
Copy link
Member

It looks like some patches in sqlite3 need to be remade:


  error: while searching for:

  */

  #define SQLITE_CORE 1

  #define SQLITE_AMALGAMATION 1

  #ifndef SQLITE_PRIVATE

  # define SQLITE_PRIVATE static

  #endif



  error: patch failed: sqlite3.c:22

  error: sqlite3.c: patch does not apply

  Checking patch sqlite3.h...

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive.cmake:147 (z_vcpkg_apply_patches)
  ports/sqlite3/portfile.cmake:10 (vcpkg_extract_source_archive)
  scripts/ports.cmake:196 (include)

@c8ef c8ef marked this pull request as ready for review January 15, 2025 13:16
@c8ef
Copy link
Contributor Author

c8ef commented Jan 15, 2025

It looks like some patches in sqlite3 need to be remade:


  error: while searching for:

  */

  #define SQLITE_CORE 1

  #define SQLITE_AMALGAMATION 1

  #ifndef SQLITE_PRIVATE

  # define SQLITE_PRIVATE static

  #endif



  error: patch failed: sqlite3.c:22

  error: sqlite3.c: patch does not apply

  Checking patch sqlite3.h...

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive.cmake:147 (z_vcpkg_apply_patches)
  ports/sqlite3/portfile.cmake:10 (vcpkg_extract_source_archive)
  scripts/ports.cmake:196 (include)

Done.

@JonLiu1993
Copy link
Member

@c8ef, When I tested the features by command ./vcpkg install sqlite3[*]:x64-windows-static, I get this error, please take a look:

FAILED: sqlite3.exe 
C:\WINDOWS\system32\cmd.exe /C "cd . && F:\Feature-test\sqlite3\downloads\tools\cmake-3.30.1-windows\cmake-3.30.1-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\sqlite3-bin.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1442~1.344\bin\Hostx64\x64\link.exe  CMakeFiles\sqlite3-bin.dir\shell.c.obj  /out:sqlite3.exe /implib:sqlite3.lib /pdb:sqlite3.exe.pdb.pdb /version:0.0 /machine:x64 /nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF   /subsystem:console  sqlite3.lib  F:\Feature-test\sqlite3\installed\x64-windows-static\lib\zlib.lib  F:\Feature-test\sqlite3\installed\x64-windows-static\lib\icuuc.lib  F:\Feature-test\sqlite3\installed\x64-windows-static\lib\icuin.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK: command "C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1442~1.344\bin\Hostx64\x64\link.exe CMakeFiles\sqlite3-bin.dir\shell.c.obj /out:sqlite3.exe /implib:sqlite3.lib /pdb:sqlite3.exe.pdb.pdb /version:0.0 /machine:x64 /nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF /subsystem:console sqlite3.lib F:\Feature-test\sqlite3\installed\x64-windows-static\lib\zlib.lib F:\Feature-test\sqlite3\installed\x64-windows-static\lib\icuuc.lib F:\Feature-test\sqlite3\installed\x64-windows-static\lib\icuin.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST:EMBED,ID=1" failed (exit code 1120) with the following output:
icuuc.lib(udata.ao) : error LNK2001: unresolved external symbol icudt74_dat

sqlite3.exe : fatal error LNK1120: 1 unresolved externals

ninja: build stopped: subcommand failed.

@c8ef
Copy link
Contributor Author

c8ef commented Jan 16, 2025

It seems that I am unable to reproduce this issue locally (since the error is related to Unicode, I have only enabled this feature)...

Installing 3/3 sqlite3[core,json1,unicode]:[email protected]...
Building sqlite3[core,json1,unicode]:[email protected]...
-- Using cached sqlite-autoconf-3480000.zip.
-- Cleaning sources at C:/Users/Mario/Documents/vcpkg/buildtrees/sqlite3/src/nf-3480000-79e4d4e825.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/Mario/Documents/vcpkg/downloads/sqlite-autoconf-3480000.zip
-- Applying patch fix-arm-uwp.patch
-- Applying patch add-config-include.patch
-- Using source at C:/Users/Mario/Documents/vcpkg/buildtrees/sqlite3/src/nf-3480000-79e4d4e825.clean
-- Found external ninja('1.11.0').
-- Configuring x64-windows-static
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Fixing pkgconfig file: C:/Users/Mario/Documents/vcpkg/packages/sqlite3_x64-windows-static/lib/pkgconfig/sqlite3.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.3.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.5.4-2-x86_64.pkg.tar.zst.
-- Using msys root at C:/Users/Mario/Documents/vcpkg/downloads/tools/msys2/21caed2f81ec917b
-- Fixing pkgconfig file: C:/Users/Mario/Documents/vcpkg/packages/sqlite3_x64-windows-static/debug/lib/pkgconfig/sqlite3.pc
-- Installing: C:/Users/Mario/Documents/vcpkg/packages/sqlite3_x64-windows-static/share/sqlite3/usage
-- Performing post-build validation
Stored binaries in 1 destinations in 902 ms.
Elapsed time to handle sqlite3:x64-windows-static: 21 s
sqlite3:x64-windows-static package ABI: 1d3caaaa26425554090829976c0d2c32d2b434d1ae171d1bad9d9b14f1a7d460
Total install time: 15 min
sqlite3 provides pkgconfig bindings.
sqlite3 provides CMake targets:

    find_package(unofficial-sqlite3 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::sqlite3::sqlite3)

@c8ef
Copy link
Contributor Author

c8ef commented Jan 17, 2025

@JonLiu1993 Please take another look🥹

@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-wnidows
  • x64-windows

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants