[portaudio] Control deps, cleanup #43323
Conversation
jimwang118
added
the
category:code-cleanup
| "supports": "!uwp", | ||
| "dependencies": [ | ||
| { | ||
| "name": "jack2", | ||
| "platform": "!ios & !osx & !windows" |
There was a problem hiding this comment.
We distribute Mixxx with Jack support on macOS and Windows.
https://github.com/mixxxdj/vcpkg/tree/2.5/overlay/ports/portaudio
I am unsure how the upstream status is right now. Do you have interest to integrate our patches?
There was a problem hiding this comment.
No extra patches to the old CMakeLists.txt. Portaudio needs to make a release.
|
Usage test passed with x64-windows triplet. |
| vcpkg_list(SET options) | ||
| if(VCPKG_TARGET_IS_WINDOWS) | ||
| vcpkg_list(APPEND options | ||
| -DPA_USE_ASIOSDK=OFF |
There was a problem hiding this comment.
This change makes the Windows version of the port barely useable, as ASIO is the standard for all proffesional audio equipment on Windows. Why not linking the VCPKG asiosdk port as dependency or default feature here?
There was a problem hiding this comment.
The original behavior is not acceptable. The port must not pick dependencies just because they are present in arbitrary locations. I can fix this broken behavior only by disabling asiosdk, because I cannot test the configuration with asiosdk.
- You can and must add a proper feature to depend on, and use, port
asiosdk. - You can and must use triplet customization to override this cmake option if you want to pick an external copy of asiosdk.
Fixes installation order issues.
Fixes
-ldlusage requirement.