[open62541] added multithreading feature #43327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:port-feature
reinder
force-pushed
the
open62541-add-multithreading-feature
branch
from
fcba389 to
fee78cb
Compare
|
@reinder, Please agreed to CLA with Microsoft. |
|
@microsoft-github-policy-service agree |
JonLiu1993
reviewed
Jan 21, 2025
Comment on lines
+44
to
+47
| if("multithreading" IN_LIST FEATURES) | ||
| set(OPEN62541_MULTITHREADING_OPTIONS -DUA_MULTITHREADING=100) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
@reinder, Thanks for your PR, I think it is unreasonable to set -DUA_MULTITHREADING=100 as the value for whether to turn on the option OPEN62541_MULTITHREADING_OPTIONS. If the user sets the multithreading value to a value other than 100, multithreading still cannot be turned on.
There was a problem hiding this comment.
@JonLiu1993 thanks the review.
The current version of the open62541 library only uses UA_MULTITHREADING >= 100, until that changes it will work. (There is one test that contains a UA_MULTITHREADING >= 200 somehow, but vcpkg skips the test anyway.)
open62541 also generates a config.h header in the include folder that #define's UA_MULTITHREADING, so there is no need for the user to set that define.
If I did understand you feedback incorrectly, please let me know. If there is a better vcpkg solution to implement this kind of feature please let me know too.
JonLiu1993
approved these changes
Jan 22, 2025
|
Tested feature
|
|
Results in Host Environment
To Reproduce
/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/open62541/install-arm64-osx-dbg-out.logAdditional context vcpkg.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42179
./vcpkg x-add-version --alland committing the result.This PR only adds a feature, no other changes are made,
p.s. This is my first vcpkg PR, feedback is welcome.