-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete handling for --x-use-aria2, avoid duplicate file hashing, and fix hash mismatch message. #43418
Conversation
…that emitted by x-download.
…sed as being part of the file name.
…ing of other branches.
This looks like a missing dependency declaration?
This looks like the %temp% race again, bison crashed.
Hmmmm looks like I missed a MAKE_DIRECTORY.
|
b8be41f
to
273200b
Compare
…fix hash mismatch message. (microsoft#43418)
Related microsoft/vcpkg-tool#1582
In microsoft/vcpkg-tool#1580 (comment) I discovered that the existing hash mismatch message was entirely broken.
Also fixed that whenever we had an existing download with a matching SHA, we were SHA512-ing it twice.
It seems like the existing
_VCPKG_INTERNAL_NO_HASH_CHECK
is broken as the only place it is used is for updating qt, and for those cases not trying to download a current version seems like an error, but I've kept the existing behavior. /cc @Neumann-AExample new output:
... now matches the current tool output in the download case except for the 'note's. (I would put the note:s there, but CMake already makes emitting reasonable errors here impossible by forcing things to be indented :( )
As an aside, I think there's an argument that the 'existing file' handling belongs in
x-download
, rather than here in CMake, but as that affects a documented interface I'm not looking to make such a change right now.