-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[etcd-cpp-apiv3] fix find cpprestsdk when build core only #43427
Conversation
c2e85ba
to
e4144ab
Compare
e4144ab
to
4646217
Compare
4646217
to
c686ef7
Compare
Waiting for etcd-cpp-apiv3/etcd-cpp-apiv3#292. |
endif() | ||
|
||
-find_dependency(cpprestsdk) | ||
+find_package(cpprestsdk QUIET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the incorrect fix. Instead, the patch should only call find_dependency
when the async
feature is enabled.
if (NOT @BUILD_ETCD_CORE_ONLY@)
find_dependency(cpprestsdk)
endif()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the reminder
Upstream has been notified and this is a minor build targeted bugfix so I think this is OK to land. Thanks for your contribution! |
./vcpkg x-add-version --all
and committing the result.etcd-cpp-apiv3 use find_dependency(cpprest), and that will return early if
cpprestsdk
is not found, which results inetcd-targets
not being properly imported when theasync
feature is not enabled.