-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] update to 11.1.3 #43549
[fmt] update to 11.1.3 #43549
Conversation
I encounter this issue when building
From what I see, it was fixed in a newer version (not yet released) of On wpilib there are some issues with |
There may be some overlapping efforts between this PR and #42936 |
The vcpkg/buildtrees/wpilib/install-x64-linux-dbg-out.log
|
"description": "WPILib is the software library package for the FIRST Robotics Competition. The core install includes wpiutil, a common utilies library, and ntcore, the base NetworkTables library.", | ||
"homepage": "https://github.com/wpilibsuite/allwpilib", | ||
"license": null, | ||
"dependencies": [ | ||
"eigen3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcpkg doesn't want vendored libraries...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dg0yt Thanks for your feedback.
I couldn't build wpilib
using eigen
version 3.4.0. I will leave this comment here, since I think it is relevant to the issue: SleipnirGroup/Sleipnir#745 (comment)
This being the case, I have used the newer eigen
version, which is bundled with wpilib
and it seems to work. Considering this, should eigen
port be updated to a newer version or what will be the best approach here ?
Continued by @jimwang118 -> #42936 |
Fixes #43548
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --all
and committing the result.