Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] update to 11.1.3 #43549

Closed
wants to merge 4 commits into from
Closed

Conversation

rremilian
Copy link
Contributor

Fixes #43548

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rremilian rremilian marked this pull request as draft January 30, 2025 12:42
@rremilian
Copy link
Contributor Author

rremilian commented Jan 30, 2025

spdlog and wpilib are failing.

I encounter this issue when building spdlog:

error: ‘template<class T, class ... Args> fmt::v11::basic_string_view<Char> spdlog::details::to_string_view’ redeclared as different kind of entity
  369 | inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {
      |                                                      ^~~~~~~~~~~~~~~~~~~

From what I see, it was fixed in a newer version (not yet released) of spdlog -> gabime/spdlog#3302

On wpilib there are some issues with fmt::v11::string_view.
I think these have to be updated too.

@miyanyan
Copy link
Contributor

miyanyan commented Feb 3, 2025

There may be some overlapping efforts between this PR and #42936

@rremilian
Copy link
Contributor Author

rremilian commented Feb 3, 2025

The wpilib error I'm getting after updating the port:

vcpkg/buildtrees/wpilib/install-x64-linux-dbg-out.log

In file included from /root/vcpkg/installed/x64-linux/include/Eigen/Householder:23,
                 from /root/vcpkg/installed/x64-linux/include/Eigen/QR:15,
                 from /root/vcpkg/buildtrees/wpilib/src/v2025.2.1-cde9d62833.clean/wpimath/src/main/native/thirdparty/sleipnir/src/autodiff/VariableMatrix.cpp:5:
/root/vcpkg/installed/x64-linux/include/Eigen/src/Householder/Householder.h: In instantiation of �~@~Xvoid Eigen::MatrixBase<Derived>::applyHouseholderOnTheLeft(const EssentialPart&, const Scalar&, Scalar*) [with EssentialPart = Eigen::VectorBlock<Eigen::Block<Eigen::Block<Eigen::Matrix<sleipnir::Variable, -1, -1>, -1, -1, false>, -1, 1, true>, -1>; Derived = Eigen::Block<Eigen::Block<Eigen::Matrix<sleipnir::Variable, -1, -1>, -1, -1, false>, -1, -1, false>; Scalar = sleipnir::Variable]�~@~Y:
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:296:35:   required from �~@~Xvoid Eigen::internal::householder_qr_inplace_unblocked(MatrixQR&, HCoeffs&, typename MatrixQR::Scalar*) [with MatrixQR = Eigen::Block<Eigen::Matrix<sleipnir::Variable, -1, -1>, -1, -1, false>; HCoeffs = Eigen::Block<Eigen::Matrix<sleipnir::Variable, -1, 1, 0, -1, 1>, -1, 1, false>; typename MatrixQR::Scalar = sleipnir::Variable]�~@~Y
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:345:39:   required from �~@~Xstatic void Eigen::internal::householder_qr_inplace_blocked<MatrixQR, HCoeffs, MatrixQRScalar, InnerStrideIsOne>::run(MatrixQR&, HCoeffs&, Eigen::Index, typename MatrixQR::Scalar*) [with MatrixQR = Eigen::Matrix<sleipnir::Variable, -1, -1>; HCoeffs = Eigen::Matrix<sleipnir::Variable, -1, 1, 0, -1, 1>; MatrixQRScalar = sleipnir::Variable; bool InnerStrideIsOne = true; Eigen::Index = long int; typename MatrixQR::Scalar = sleipnir::Variable]�~@~Y
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:416:73:   required from �~@~Xvoid Eigen::HouseholderQR<MatrixType>::computeInPlace() [with _MatrixType = Eigen::Matrix<sleipnir::Variable, -1, -1>]�~@~Y
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:181:7:   required from �~@~XEigen::HouseholderQR<MatrixType>& Eigen::HouseholderQR<MatrixType>::compute(const Eigen::EigenBase<OtherDerived>&) [with InputType = Eigen::Matrix<sleipnir::Variable, -1, -1>; _MatrixType = Eigen::Matrix<sleipnir::Variable, -1, -1>]�~@~Y
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:114:14:   required from �~@~XEigen::HouseholderQR<MatrixType>::HouseholderQR(const Eigen::EigenBase<OtherDerived>&) [with InputType = Eigen::Matrix<sleipnir::Variable, -1, -1>; _MatrixType = Eigen::Matrix<sleipnir::Variable, -1, -1>]�~@~Y
/root/vcpkg/installed/x64-linux/include/Eigen/src/QR/HouseholderQR.h:429:10:   required from �~@~Xconst Eigen::HouseholderQR<typename Eigen::DenseBase<Derived>::PlainObject> Eigen::MatrixBase<Derived>::householderQr() const [with Derived = Eigen::Matrix<sleipnir::Variable, -1, -1>; typename Eigen::DenseBase<Derived>::PlainObject = Eigen::Matrix<sleipnir::Variable, -1, -1>]�~@~Y
/root/vcpkg/buildtrees/wpilib/src/v2025.2.1-cde9d62833.clean/wpimath/src/main/native/thirdparty/sleipnir/src/autodiff/VariableMatrix.cpp:78:43:   required from here
/root/vcpkg/installed/x64-linux/include/Eigen/src/Householder/Householder.h:125:15: error: return type of �~@~Xsleipnir::EqualityConstraints sleipnir::operator==(LHS&&, RHS&&) [with LHS = const Variable&; RHS = Variable]�~@~Y is not �~@~Xbool�~@~Y
  125 |   else if(tau != Scalar(0))
      |           ~~~~^~~~~~~~~~~~

"description": "WPILib is the software library package for the FIRST Robotics Competition. The core install includes wpiutil, a common utilies library, and ntcore, the base NetworkTables library.",
"homepage": "https://github.com/wpilibsuite/allwpilib",
"license": null,
"dependencies": [
"eigen3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcpkg doesn't want vendored libraries...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt Thanks for your feedback.

I couldn't build wpilib using eigen version 3.4.0. I will leave this comment here, since I think it is relevant to the issue: SleipnirGroup/Sleipnir#745 (comment)
This being the case, I have used the newer eigen version, which is bundled with wpilib and it seems to work. Considering this, should eigen port be updated to a newer version or what will be the best approach here ?

@LilyWangLL LilyWangLL self-assigned this Feb 5, 2025
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Feb 5, 2025
@rremilian
Copy link
Contributor Author

Continued by @jimwang118 -> #42936

@rremilian rremilian closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fmt] update to 11.1.3
4 participants